ubuntu-touch-coreapps-reviewers team mailing list archive

[Kunal Parmar <pkunal.parmar@xxxxxxxxx>]

Kunal Parmar has proposed merging lp:~pkunal-parmar/ubuntu-calendar-app/ReadOnlyCal into lp:ubuntu-calendar-app.

Commit message:
resolves bug #1347836

Requested reviews:
  Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
  Bug #1347836 in Ubuntu Calendar App: "Events saved to birthdays calendar don't appear in timeline"
  https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1347836

For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/ReadOnlyCal/+merge/261075

resolves bug #1347836

Events saved to birthdays calendar don't appear in timeline
-- 
Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~pkunal-parmar/ubuntu-calendar-app/ReadOnlyCal into lp:ubuntu-calendar-app.

=== modified file 'EventListModel.qml'
--- EventListModel.qml	2014-09-28 05:25:31 +0000
+++ EventListModel.qml	2015-06-04 12:17:59 +0000
@@ -76,6 +76,19 @@
         return cals;
 	}
 
+    function getWritableCollections(){
+        var cals = [];
+        var collections = eventModel.collections;
+        for(var i = 0 ; i < collections.length ; ++i) {
+            var cal = collections[i];
+            if( cal.extendedMetaData("collection-type") === "Calendar" &&
+                    cal.extendedMetaData("collection-readonly") === false ) {
+                cals.push(cal);
+            }
+        }
+        return cals;
+    }
+
     onStartPeriodChanged: {
         isLoading = true
     }

=== modified file 'NewEvent.qml'
--- NewEvent.qml	2015-05-22 12:25:24 +0000
+++ NewEvent.qml	2015-06-04 12:17:59 +0000
@@ -482,7 +482,7 @@
                     }
 
                     containerHeight: itemHeight * 4
-                    model: root.model.getCollections();
+                    model: root.model.getWritableCollections();
 
                     delegate: OptionSelectorDelegate{
                         text: modelData.name