ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/ubuntu-weather-app/reboot-stay-on-location-upon-refresh into lp:ubuntu-weather-app/reboot.

Commit message:
* Do not lose currentIndex when pull to refresh.

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)

For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-stay-on-location-upon-refresh/+merge/261317

* Do not lose currentIndex when pull to refresh.

Currently if the user has 2 or more locations and the user does a "Pull to refresh" on any location the user is brought to the location at index 0. The user should say on the location that the refresh was done upon.
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-stay-on-location-upon-refresh into lp:ubuntu-weather-app/reboot.

=== modified file 'app/ui/HomePage.qml'
--- app/ui/HomePage.qml	2015-05-29 02:38:23 +0000
+++ app/ui/HomePage.qml	2015-06-06 17:49:27 +0000
@@ -108,6 +108,7 @@
             parent: locationFlickable
             refreshing: false
             onRefresh: {
+                locationPages.loaded = false
                 refreshing = true
                 refreshData(false, true)
             }