ubuntu-touch-coreapps-reviewers team mailing list archive

[Niklas Wenzel <nikwen.developer@xxxxxxxxx>]

Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-calculator-app/fix-autopilot-empty-square into lp:ubuntu-calculator-app.

Commit message:
Use longer swipe in autopilot tests for revealing the scientific keyboard

Requested reviews:
  Ubuntu Calculator Developers (ubuntu-calculator-dev)
Related bugs:
  Bug #1464571 in Ubuntu Calculator App: "Sometimes autopilot tests fail because of too short swipes"
  https://bugs.launchpad.net/ubuntu-calculator-app/+bug/1464571

For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/fix-autopilot-empty-square/+merge/261829

Use longer swipe in autopilot tests for revealing the scientific keyboard. If the bug appears again, the reason lies in the QML code. However, it works fine for me so far.
-- 
Your team Ubuntu Calculator Developers is requested to review the proposed merge of lp:~nikwen/ubuntu-calculator-app/fix-autopilot-empty-square into lp:ubuntu-calculator-app.

=== modified file 'tests/autopilot/ubuntu_calculator_app/__init__.py'
--- tests/autopilot/ubuntu_calculator_app/__init__.py	2015-04-10 19:33:11 +0000
+++ tests/autopilot/ubuntu_calculator_app/__init__.py	2015-06-12 10:09:52 +0000
@@ -143,13 +143,14 @@
     def _scientific_keyboard(self, enable=True):
         y = (self.globalRect[1] + self.globalRect[3] / 2) + 150
 
-        x_start = self.globalRect[0] + self.globalRect[2] - 20
-        x_stop = self.globalRect[0] + self.globalRect[2] - 20
+        x_middle = self.globalRect[0] + self.globalRect[2] / 2
 
         if enable:
-            x_stop = x_stop - 200
+            x_start = x_middle + 150
+            x_stop = x_middle - 150
         else:
-            x_start = x_start - 300
+            x_start = x_middle - 150
+            x_stop = x_middle + 150
 
         self.pointing_device.drag(x_start, y, x_stop, y)