← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~mzanetti/reminders-app/animated-delete into lp:reminders-app

 

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/animated-delete into lp:reminders-app.

Commit message:
Add an animation when deleting things

Requested reviews:
  Ubuntu Reminders app developers (reminders-app-dev)

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/animated-delete/+merge/261904
-- 
Your team Ubuntu Reminders app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/animated-delete into lp:reminders-app.
=== modified file 'src/app/qml/ui/NotebooksPage.qml'
--- src/app/qml/ui/NotebooksPage.qml	2015-03-15 20:00:21 +0000
+++ src/app/qml/ui/NotebooksPage.qml	2015-06-14 00:36:42 +0000
@@ -116,6 +116,10 @@
                 NotesStore.refreshNotebooks();
             }
 
+            displaced: Transition {
+                UbuntuNumberAnimation { property: "y"}
+            }
+
             delegate: NotebooksDelegate {
                 width: parent.width
                 height: units.gu(10)

=== modified file 'src/app/qml/ui/NotesPage.qml'
--- src/app/qml/ui/NotesPage.qml	2015-06-11 22:02:25 +0000
+++ src/app/qml/ui/NotesPage.qml	2015-06-14 00:36:42 +0000
@@ -172,6 +172,10 @@
             NotesStore.refreshNotes();
         }
 
+        displaced: Transition {
+            UbuntuNumberAnimation { property: "y"}
+        }
+
         delegate: NotesDelegate {
             title: model.title
             date: notes.sortOrder == Notes.SortOrderUpdatedOldest || notes.sortOrder == Notes.SortOrderUpdatedNewest ?

=== modified file 'src/app/qml/ui/TagsPage.qml'
--- src/app/qml/ui/TagsPage.qml	2015-03-15 20:00:21 +0000
+++ src/app/qml/ui/TagsPage.qml	2015-06-14 00:36:42 +0000
@@ -80,6 +80,10 @@
                 NotesStore.refreshTags();
             }
 
+            displaced: Transition {
+                UbuntuNumberAnimation { property: "y"}
+            }
+
             delegate: TagsDelegate {
                 width: parent.width
                 height: units.gu(10)


Follow ups