ubuntu-touch-coreapps-reviewers team mailing list archive

[Niklas Wenzel <nikwen.developer@xxxxxxxxx>]

Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-filemanager-app/remove-popover-workaround into lp:ubuntu-filemanager-app.

Commit message:
Remove popover workaround for LP: #1395118

Requested reviews:
  Ubuntu File Manager Developers (ubuntu-filemanager-dev)
Related bugs:
  Bug #1395118 in Ubuntu File Manager App: "ActionSelectionPopover does not handle the 'visible' property of actions properly"
  https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1395118

For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-filemanager-app/remove-popover-workaround/+merge/261909

Remove popover workaround for LP: #1395118.
-- 
Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nikwen/ubuntu-filemanager-app/remove-popover-workaround into lp:ubuntu-filemanager-app.

=== modified file 'src/app/qml/ui/FolderListPage.qml'
--- src/app/qml/ui/FolderListPage.qml	2015-03-04 10:02:30 +0000
+++ src/app/qml/ui/FolderListPage.qml	2015-06-14 14:24:42 +0000
@@ -526,23 +526,6 @@
                 archiveType = getArchiveType(actionSelectionPopover.model.fileName)
             }
 
-            delegate: Empty { // NOTE: This is a workaround for LP: #1395118 and should be removed as soon as the patch for upstream gets released (https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1395118)
-                id: listItem
-                Label {
-                    text: listItem.text
-                    anchors {
-                        verticalCenter: parent.verticalCenter
-                        horizontalCenter: parent.horizontalCenter
-                    }
-                    wrapMode: Text.Wrap
-                    color: Theme.palette.normal.overlayText
-                }
-                /*! \internal */
-                onTriggered: actionSelectionPopover.hide()
-                visible: enabled && ((action === undefined) || action.visible)
-                height: visible ? implicitHeight : 0
-            }
-
             actions: ActionList {
                 Action {
                     text: i18n.tr("Cut")