ubuntu-touch-coreapps-reviewers team mailing list archive

[Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>]

Review: Needs Fixing

Couple minor typos (I'm being nitpicky now)
- The debian changelog entry should include the bug number..so please append (LP: #1442518) to the end of that sentence.

- var now=new Date() should be var now = new Date() to maintain consistency

- Please leave gaps between the arguments in alarmData.date = new Date(now.getFullYear(),now.getMonth(),now.getDate()+1,alarmData.date.getHours(),alarmData.date.getMinutes(),0,0)

it should look like

alarmData.date = new Date(now.getFullYear(), now.getMonth(), now.getDate()+1, alarmData.date.getHours(), alarmData.date.getMinutes(), 0, 0)

This will improve clarity
-- 
https://code.launchpad.net/~themeles/ubuntu-clock-app/bugfix-1442518/+merge/261910
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.