ubuntu-touch-coreapps-reviewers team mailing list archive

[Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>]

Review: Needs Information

Thanks Nicholas for the MP. Just a couple of minor things,

In your MP description you mention that "It also should now properly detect a cmake build, and not require you to build in a certain folder." .. I suppose you're talking about the lack of need to create builddir like it was mandatory to do before. However when I tried running the tests without creating a separate build dir, I wasn't able to run autopilot tests. The errors can be found at http://paste.ubuntu.com/11737058/.

On creating a builddir, cmake .. && make and then running the test, everything worked correctly. The readme still informs the user to create a builddir, so w.r.t everything is good.

Is this what you expected?
-- 
https://code.launchpad.net/~nskaggs/ubuntu-clock-app/update-test-layout/+merge/262271
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.