ubuntu-touch-coreapps-reviewers team mailing list archive

[Carlos Jose Mazieri <carlos.mazieri@xxxxxxxxx>]

Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-final-new into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-13-new as a prerequisite.

Commit message:

It allows the filemager to browse Samba items by entering any valid url starting with "smb://" or "cifs://".

Requested reviews:
  Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot): continuous-integration
  Ubuntu File Manager Developers (ubuntu-filemanager-dev)

For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-final-new/+merge/262526

It replaces https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-final/+merge/253131

It allows the filemager to browse Samba items by entering any valid url starting with "smb://" or "cifs://".

To test: Menu -> GoTo, type smb:// or cifs://

The property "isDir" should be changed in some places to "isBrowsable", the difference is that "isDir" allows remove/copy/cut while "isBrowsable" just means the item is a container and may have sub items.
-- 
Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-final-new into lp:ubuntu-filemanager-app.

=== modified file 'src/app/qml/ui/FolderListPage.qml'
--- src/app/qml/ui/FolderListPage.qml	2015-03-04 10:02:30 +0000
+++ src/app/qml/ui/FolderListPage.qml	2015-06-20 19:32:16 +0000
@@ -888,7 +888,7 @@
     }
 
     function itemClicked(model) {
-        if (model.isDir) {
+        if (model.isBrowsable) {
             if (model.isReadable && model.isExecutable) {
                 console.log("Changing to dir", model.filePath)
                 goTo(model.filePath)