ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~nikwen/ubuntu-terminal-app/keyboard-shortcuts into lp:ubuntu-terminal-app

To: Niklas Wenzel <nikwen.developer@xxxxxxxxx>
From: Filippo Scognamiglio <flscogna@xxxxxxxxx>
Date: Mon, 22 Jun 2015 22:16:16 -0000
In-reply-to: <20150611221922.12617.23615.launchpad@ackee.canonical.com>
Reply-to: mp+261787@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Hi Niklas. I approve the work here, but it could use some refactoring. Please move the shortcut logic to a separate component (shortcutManager or something like that) in order to increase readability and maintainability. We should also investigate the use of Actions which in the future will probably support shortcuts natively.
-- 
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/keyboard-shortcuts/+merge/261787
Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app.

References

[Merge] lp:~nikwen/ubuntu-terminal-app/keyboard-shortcuts into lp:ubuntu-terminal-app
From: Niklas Wenzel, 2015-06-11