ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~mihirsoni/ubuntu-calendar-app/1466667 into lp:ubuntu-calendar-app

To: Mihir Soni <mihirsoni.123@xxxxxxxxx>
From: "Gary.Wang" <Gary.Wang@xxxxxxxxxxxxx>
Date: Thu, 25 Jun 2015 05:20:23 -0000
In-reply-to: <20150623170450.19465.18826.launchpad@ackee.canonical.com>
Reply-to: mp+262763@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Personally,I don't think there is a need to introduce new property(eventDuration) in this case,since we have properties startdate and enddate now.

Pls take a look at this patch:
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1466667
-- 
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/1466667/+merge/262763
Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app.

References

[Merge] lp:~mihirsoni/ubuntu-calendar-app/1466667 into lp:ubuntu-calendar-app
From: Mihir Soni, 2015-06-23