ubuntu-touch-coreapps-reviewers team mailing list archive

[David Planella <david.planella@xxxxxxxxxx>]

Review: Approve

Looks good, and after testing it, works well too. Thanks!

Just a couple of notes that should not block this from landing:

1) On debian/changelog, you can use the "(LP: #<bug number>)" syntax to mark bugs as closed, instead of a URL. See [1] for details.

2) While building the package, Lintian complains with the following errors and warnings:

W: ubuntu-docviewer-app source: diff-contains-bzr-control-dir .bzr
E: ubuntu-docviewer-app source: build-depends-on-metapackage build-depends: qt5-default
E: ubuntu-docviewer-app: missing-dependency-on-libc needed by usr/bin/ubuntu-docviewer-app and 2 others
W: ubuntu-docviewer-app: binary-without-manpage usr/bin/ubuntu-docviewer-app
W: ubuntu-docviewer-app: desktop-mime-but-no-exec-code usr/share/applications/com.ubuntu.docviewer.desktop

I've not looked at all of them, but I think the last one [2] could be fixed by specifying an argument to the Exec line in the .desktop file.

[1] http://packaging.ubuntu.com/html/fixing-a-bug-example.html
[2] https://lintian.debian.org/tags/desktop-mime-but-no-exec-code.html
-- 
https://code.launchpad.net/~gang65/ubuntu-docviewer-app/ubuntu-docviewer-app-icon-fix/+merge/262911
Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app.