ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date
Re: [Merge] lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-desktop-install-fix into lp:ubuntu-calculator-app

To: mp+262799@xxxxxxxxxxxxxxxxxx
From: David Planella <david.planella@xxxxxxxxxx>
Date: Thu, 25 Jun 2015 07:08:03 -0000
In-reply-to: <20150623224422.24703.40070.launchpad@ackee.canonical.com>
Reply-to: mp+262799@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx
Review: Needs Fixing

Just a few additional comments on debian/changelog and the launcher script. Looking good now, though!

Diff comments:

> === modified file 'CMakeLists.txt'
> --- CMakeLists.txt	2015-04-14 16:42:56 +0000
> +++ CMakeLists.txt	2015-06-24 20:32:08 +0000
> @@ -27,22 +27,21 @@
>  
>  include(GNUInstallDirs)
>  
> -set(APP_NAME                        ubuntu-calculator-app)
> +set(APP_NAME                        calculator-app)
>  set(APP_HARDCODE                    ubuntu-calculator-app)
>  set(AUTOPILOT_DIR                   ubuntu_calculator_app)
>  set(MAIN_QML                        ${APP_HARDCODE}.qml)
> -set(ICON                            "${APP_HARDCODE}.png")
> +set(ICON_FILE                       "${APP_HARDCODE}.png")
>  set(DESKTOP_FILE                    "${APP_HARDCODE}.desktop")
> -set(AUTOPILOT_DIR                   ubuntu_calculator_app)
>  set(APP_VERSION                     2.0)
> +set(AUTOPILOT_DIR                   ubuntu_calculator_app)
>  
>  if(CLICK_MODE)
>    set(CMAKE_INSTALL_PREFIX "/")
>    set(UBUNTU-CALCULATOR-APP_DIR    "${CMAKE_INSTALL_DATADIR}/qml")
>  
>    set(QT_IMPORTS_DIR "${CMAKE_INSTALL_LIBDIR}")
> -  set(EXEC "qmlscene $@ ${UBUNTU-CALCULATOR-APP_DIR}/${MAIN_QML}")
> -  set(MODULE_PATH ${QT_IMPORTS_DIR})
> +  set(EXEC "qmlscene -qt5 $@ ${UBUNTU-CALCULATOR-APP_DIR}/${MAIN_QML}")
>    if(NOT BZR_REVNO)
>      execute_process(
>        COMMAND bzr revno
> @@ -76,8 +75,14 @@
>    configure_file(${UBUNTU_MANIFEST_PATH} ${CMAKE_CURRENT_BINARY_DIR}/manifest.json)
>    install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json DESTINATION ${CMAKE_INSTALL_PREFIX})
>    install(FILES "${APP_HARDCODE}.apparmor" DESTINATION ${CMAKE_INSTALL_PREFIX})
> +  set(ICON ${ICON_FILE})
>  else(CLICK_MODE)
> -  set(EXEC "qmlscene $@ -I ${MODULE_PATH}  ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR}/${MAIN_QML}")
> +  set(ICON ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR}/${ICON_FILE})
> +  set(EXEC ${APP_NAME})
> +  configure_file(app/${APP_NAME}.in
> +    ${CMAKE_CURRENT_BINARY_DIR}/${APP_NAME})
> +  install(PROGRAMS ${CMAKE_CURRENT_BINARY_DIR}/${APP_NAME}
> +    DESTINATION ${CMAKE_INSTALL_BINDIR})
>  endif(CLICK_MODE)
>  
>  file(GLOB_RECURSE I18N_SRC_FILES
> 
> === modified file 'app/CMakeLists.txt'
> --- app/CMakeLists.txt	2015-04-14 16:42:56 +0000
> +++ app/CMakeLists.txt	2015-06-24 20:32:08 +0000
> @@ -3,12 +3,8 @@
>    add_custom_target(ubuntu-calculator-app_QMlFiles ALL SOURCES ${QML_JS_FILES})
>  endif(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
>  
> -if(CLICK_MODE)
> -  set(ICON ${ICON})
> -  install(FILES graphics/${ICON} DESTINATION ${CMAKE_INSTALL_PREFIX})
> -endif(CLICK_MODE)
> -
> -install(FILES ${MAIN_QML} DESTINATION ${UBUNTU-CALCULATOR-APP_DIR})
> +install(FILES graphics/${ICON_FILE} DESTINATION ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR})
> +install(FILES ${MAIN_QML} DESTINATION ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR})
>  
>  add_subdirectory(engine)
>  add_subdirectory(graphics)
> 
> === added file 'app/calculator-app.in'
> --- app/calculator-app.in	1970-01-01 00:00:00 +0000
> +++ app/calculator-app.in	2015-06-24 20:32:08 +0000
> @@ -0,0 +1,3 @@
> +#!/bin/bash

Just a nitpick, and more a question than a required fix. Do we need bash features for this small script? Could it not be just #!/bin/sh ?

> +export QT_SELECT=qt5
> +exec qmlscene @CMAKE_INSTALL_PREFIX@/@UBUNTU-CALCULATOR-APP_DIR@/@MAIN_QML@
> 
> === modified file 'debian/changelog'
> --- debian/changelog	2014-12-11 11:09:09 +0000
> +++ debian/changelog	2015-06-24 20:32:08 +0000
> @@ -1,3 +1,45 @@
> +ubuntu-calculator-app (2.0.197) vivid; urgency=medium
> +
> +  [ Bartosz Kosiorek ]
> +  * Do not allow swiping in Landscape mode. 
> +    Fixes: https://bugs.launchpad.net/bugs/1466635.

Please use the  (LP: #<bug number>) syntax instead of full bug URLs. E.g.:

* Do not allow swiping in Landscape mode (LP: #1466635).

See http://packaging.ubuntu.com/html/fixing-a-bug-example.html for more details.

> +  * Fix keyboard shortcuts (eg. Ctrl+C). 
> +    Fixes: https://bugs.launchpad.net/bugs/1466634.

Please use the  (LP: #<bug number>) syntax instead of full bug URLs.

> +  * Add additional comments to logaritm and modulo 
> +    to avoid confusion during translation. 
> +    Fixes: https://bugs.launchpad.net/bugs/1465297.

Please use the  (LP: #<bug number>) syntax instead of full bug URLs.

> +  * Fix display issue. 
> +    Fixes: https://bugs.launchpad.net/bugs/1465996.

Please use the  (LP: #<bug number>) syntax instead of full bug URLs.

> +
> +  [ Nicholas Skaggs ]
> +  * Fix testability for screen components.
> +
> +  [ Niklas Wenzel ]
> +  * Use longer swipe in autopilot tests for revealing the scientific keyboard. 
> +    Fixes: https://bugs.launchpad.net/bugs/1464571.

Please use the  (LP: #<bug number>) syntax instead of full bug URLs.

> +  * Fix typing special characters on hardware keyboards. 
> +    Fixes: https://bugs.launchpad.net/bugs/1449037.

Please use the  (LP: #<bug number>) syntax instead of full bug URLs.

> +
> +  [ Victor Thompson ]
> +  * Change favorites translatable string. 
> +    Fixes: https://bugs.launchpad.net/bugs/1464463.

Please use the  (LP: #<bug number>) syntax instead of full bug URLs.

> +
> + -- Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>  Fri, 24 Jul 2015 12:00:05 +0100
> +
> +ubuntu-calculator-app (2.0.182) vivid; urgency=medium
> +  * Add haptic feedback to buttons
> +  * Update math.js library. http://pad.lv/1439846

Please use the  (LP: #<bug number>) syntax instead of full bug URLs.

> +  * Enable 'bug number' support to fix floating point math. 
> +    http://pad.lv/1445152

Please use the  (LP: #<bug number>) syntax instead of full bug URLs.

> +  * Modify splash screen. http://pad.lv/1377638

Please use the  (LP: #<bug number>) syntax instead of full bug URLs.

> +  * Fix keyboard focus and disappearing cursor bug. http://pad.lv/1431548

Please use the  (LP: #<bug number>) syntax instead of full bug URLs.

> +  * Fix directory layout for AP tests. http://pad.lv/1443680

Please use the  (LP: #<bug number>) syntax instead of full bug URLs.

> +  * Modified layout to fit design
> +  * Fix issue with building which corrupted translations
> +  * Updated translations
> +
> + -- Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>  Thu, 15 Jun 2015 12:00:05 +0100
> +
>  ubuntu-calculator-app (0.1) vivid; urgency=low
>  
>    * Initial release
> 


-- 
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-desktop-install-fix/+merge/262799
Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app.
References

[Merge] lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-desktop-install-fix into lp:ubuntu-calculator-app
From: Bartosz Kosiorek, 2015-06-23