ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/ubuntu-weather-app/reboot-fix-settings-listitems-offset into lp:ubuntu-weather-app/reboot.

Commit message:
Make SettingsPage main ListItems non-flickable.

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)

For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-fix-settings-listitems-offset/+merge/263206

Make SettingsPage main ListItems non-flickable. This fixes the offset seen when the Settings page is first loaded.
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-fix-settings-listitems-offset into lp:ubuntu-weather-app/reboot.

=== modified file 'app/ui/SettingsPage.qml'
--- app/ui/SettingsPage.qml	2015-06-21 14:54:05 +0000
+++ app/ui/SettingsPage.qml	2015-06-28 22:55:42 +0000
@@ -23,31 +23,24 @@
 Page {
     title: i18n.tr("Settings")
 
-    Flickable {
-        clip: true
+    Column {
+        id: settingsColumn
+
         anchors.fill: parent
-        contentHeight: settingsColumn.height
-        height: parent.height
-
-        Column {
-            id: settingsColumn
-
-            anchors.fill: parent
-
-            StandardListItem {
-                title: i18n.tr("Units")
-                onClicked: mainPageStack.push(Qt.resolvedUrl("settings/UnitsPage.qml"))
-            }
-
-            StandardListItem {
-                title: i18n.tr("Data Provider")
-                onClicked: mainPageStack.push(Qt.resolvedUrl("settings/DataProviderPage.qml"))
-            }
-
-            StandardListItem {
-                title: i18n.tr("Refresh Interval")
-                onClicked: mainPageStack.push(Qt.resolvedUrl("settings/RefreshIntervalPage.qml"))
-            }
+
+        StandardListItem {
+            title: i18n.tr("Units")
+            onClicked: mainPageStack.push(Qt.resolvedUrl("settings/UnitsPage.qml"))
+        }
+
+        StandardListItem {
+            title: i18n.tr("Data Provider")
+            onClicked: mainPageStack.push(Qt.resolvedUrl("settings/DataProviderPage.qml"))
+        }
+
+        StandardListItem {
+            title: i18n.tr("Refresh Interval")
+            onClicked: mainPageStack.push(Qt.resolvedUrl("settings/RefreshIntervalPage.qml"))
         }
     }
 }