ubuntu-touch-coreapps-reviewers team mailing list archive

[Andrew Hayzen <ahayzen@xxxxxxxxx>]

Andrew Hayzen has proposed merging lp:~ahayzen/music-app/fix-1469452-content-hub-finalised into lp:music-app.

Commit message:
* Tell content-hub we have finished with the activeTransfer

Requested reviews:
  Music App Developers (music-app-dev)
Related bugs:
  Bug #1469452 in Ubuntu Music App: "After importing files via ContentHub files won't be deleted"
  https://bugs.launchpad.net/music-app/+bug/1469452

For more details, see:
https://code.launchpad.net/~ahayzen/music-app/fix-1469452-content-hub-finalised/+merge/263287

* Tell content-hub we have finished with the activeTransfer

This tells content-hub that we have finished with the files so any temporary caches ones in ~/.cache/com.ubuntu.music/HubIncoming/{X}/ can be removed.

Testing:
* Test that content-hub still works
* Test that the directory created in HubIncoming is deleted when the files are moved to ~/Music/Imported (use `watch ls -l` as it gets removed quite quickly after the app starts)
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~ahayzen/music-app/fix-1469452-content-hub-finalised into lp:music-app.

=== modified file 'app/components/Helpers/ContentHubHelper.qml'
--- app/components/Helpers/ContentHubHelper.qml	2015-06-28 03:06:49 +0000
+++ app/components/Helpers/ContentHubHelper.qml	2015-06-29 20:36:45 +0000
@@ -153,6 +153,9 @@
                 var errordialog = PopupUtils.open(Qt.resolvedUrl("../Dialog/ContentHubErrorDialog.qml"), mainView)
                 errordialog.errorText = err.join("\n")
             }
+
+            // tell content-hub we are finished with the files
+            activeTransfer.finalize();
         }
     }