ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/music-app/fix-console-errors-child-pages into lp:music-app.

Commit message:
Fix console errors for other pages with children that do not change.

Requested reviews:
  Music App Developers (music-app-dev)

For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-console-errors-child-pages/+merge/263451

Fix console errors for other pages with children that do not change. This fixes a console warning that really has no affect (it appears) that was introduced in commit #874.
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/fix-console-errors-child-pages into lp:music-app.

=== modified file 'app/ui/SongsView.qml'
--- app/ui/SongsView.qml	2015-06-27 21:06:26 +0000
+++ app/ui/SongsView.qml	2015-07-01 01:43:29 +0000
@@ -54,7 +54,7 @@
     property bool loaded: false  // used to detect difference between first and further loads
 
     onVisibleChanged: {
-        if (page.childrenChanged) {
+        if (page !== undefined && page.childrenChanged) {
             page.childrenChanged = false
             refreshWaitTimer.start()
         }