ubuntu-touch-coreapps-reviewers team mailing list archive

[Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>]

Review: Needs Fixing

Thanks Bartosz for the MP. I am afraid however that this will not work. The AlarmSettingsPage is basically displaying the values supported by indicator-datetime  (which does the actual ringing of the alarms). And indicator-datetime does not support snooze time of more than 15 minutes.

You can take a look at https://bazaar.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk.15.10/view/head:/data/com.canonical.indicator.datetime.AlarmProperties.xml to check the supported values for snooze duration. You will notice that the snooze duration has a range between [1-15] minutes. Anything higher will lead to an error.

Do you test this MP and see if the alarms actually snoozed for more than 15 minutes?

I see two things that need to be fixed,

1) Indicator-datetime extends the snooze duration range to [1-30] minutes for this MP to work.
2) I need a confirmation from the design team that they are fine with this extension. 
-- 
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-snooze-time-extend/+merge/263846
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.