ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/music-app/bigger-play-button into lp:music-app.

Commit message:
Make play/pause button in the toolbar larger.

Requested reviews:
  Music App Developers (music-app-dev)

For more details, see:
https://code.launchpad.net/~vthompson/music-app/bigger-play-button/+merge/264143

Make play/pause button in the toolbar larger.

The new icon resources for "media-playback-pause" and "media-playback-play" appear a bit smaller than before at the size the toolbar was using them. This is MP has the play button a bit larger than the play button was in the toolbar previously.

Previously with new resources: http://i.imgur.com/CeHf3Ij.png
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/bigger-play-button into lp:music-app.

=== modified file 'app/components/MusicToolbar.qml'
--- app/components/MusicToolbar.qml	2015-05-03 16:22:31 +0000
+++ app/components/MusicToolbar.qml	2015-07-08 13:32:06 +0000
@@ -104,7 +104,7 @@
                     verticalCenter: parent.verticalCenter
                 }
                 color: "#FFF"
-                height: units.gu(2.5)
+                height: units.gu(4)
                 name: player.playbackState === MediaPlayer.PlayingState ?
                           "media-playback-pause" : "media-playback-start"
                 objectName: "disabledSmallPlayShape"
@@ -203,7 +203,7 @@
                     verticalCenter: parent.verticalCenter
                 }
                 color: "#FFF"
-                height: units.gu(2.5)
+                height: units.gu(4)
                 name: player.playbackState === MediaPlayer.PlayingState ?
                           "media-playback-pause" : "media-playback-start"
                 objectName: "playShape"