ubuntu-touch-coreapps-reviewers team mailing list archive
-
ubuntu-touch-coreapps-reviewers team
-
Mailing list archive
-
Message #03491
[Merge] lp:~pkunal-parmar/ubuntu-calendar-app/ReminderRepeat into lp:ubuntu-calendar-app
Kunal Parmar has proposed merging lp:~pkunal-parmar/ubuntu-calendar-app/ReminderRepeat into lp:ubuntu-calendar-app.
Commit message:
Resolves Bug #1470583
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/ReminderRepeat/+merge/264488
Reminder repeat and delay changed
Resolves Bug #1470583
--
Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~pkunal-parmar/ubuntu-calendar-app/ReminderRepeat into lp:ubuntu-calendar-app.
=== modified file 'EventReminder.qml'
--- EventReminder.qml 2014-11-11 12:41:18 +0000
+++ EventReminder.qml 2015-07-12 03:38:10 +0000
@@ -37,13 +37,26 @@
head.backAction: Action{
iconName:"back"
onTriggered:{
- visualReminder.repetitionCount = 3;
- visualReminder.repetitionDelay = 120;
+ var repeatCount = 3;
+ var repeatDelay = 5 * 60;
+
+ print("reminder time : " + reminderTime);
+
+ //reminder on event time
+ if( reminderTime === 0 ) {
+ repeatCount = 0;
+ repeatDelay = 0;
+ } else if( reminderTime === 300) { //5 min
+ repeatCount = 1;
+ }
+
+ visualReminder.repetitionCount = repeatCount;
+ visualReminder.repetitionDelay = repeatDelay;
visualReminder.message = eventTitle
visualReminder.secondsBeforeStart = reminderTime;
- audibleReminder.repetitionCount = 3;
- audibleReminder.repetitionDelay = 120;
+ audibleReminder.repetitionCount = repeatCount;
+ audibleReminder.repetitionDelay = repeatDelay;
audibleReminder.secondsBeforeStart = reminderTime;
pop();
Follow ups