ubuntu-touch-coreapps-reviewers team mailing list archive

[Stefano Verzegnassi <stefano92.100@xxxxxxxxx>]

Review: Approve

I've tested the branch and it LGTM.

According to LOK documentation: https://docs.libreoffice.org/libreofficekit.html
"Currently only bitmap-buffer rendering is supported, with a 32-bit RGBA colourspace (further alternatives could feasibly be implemented as needed)."
Also, in the example code provided by Bjoern, the tiles were rendered 4 bytes per pixel.

My feeling is that LOK returns a fixed "FF" value for the alpha channel. Even if it doesn't, I can't see any valid reason for which we could support trasparency in the view.
Keeping the fixed alpha value of QImage::Format_RGB32 seems a good deal and benchmarking the time required for a rendering confirms that there's some improvements in performance.

-- 
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/lo-tiled-rendering-pixel-shift-bug/+merge/264506
Your team Ubuntu Document Viewer Developers is subscribed to branch lp:~ubuntu-docviewer-dev/ubuntu-docviewer-app/lo-tiled-rendering.