ubuntu-touch-coreapps-reviewers team mailing list archive

[Nicholas Skaggs <nskaggs@xxxxxxxxxx>]

Nicholas Skaggs has proposed merging lp:~nskaggs/ubuntu-clock-app/fix-jenkins-builds into lp:ubuntu-clock-app.

Commit message:
Disable unit tests that require external depends

Requested reviews:
  Ubuntu Clock Developers (ubuntu-clock-dev)

For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-clock-app/fix-jenkins-builds/+merge/264932

Some unit testing tweaks for jenkins
-- 
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-clock-app/fix-jenkins-builds into lp:ubuntu-clock-app.

=== modified file 'tests/autopilot/run'
--- tests/autopilot/run	2014-08-07 18:19:39 +0000
+++ tests/autopilot/run	2015-07-15 22:08:18 +0000
@@ -1,13 +1,13 @@
 #!/bin/bash
 
-if [[ -z `which autopilot` ]]; then
-  echo "Autopilot is not installed. Skip"
+if [[ -z `which autopilot3` ]]; then
+  echo "Autopilot3 is not installed. Skip"
   exit
 fi
 
 SCRIPTPATH=`dirname $0`
 pushd ${SCRIPTPATH}
-autopilot run ubuntu_clock_app
+autopilot3 run ubuntu_clock_app
 retcode=$?
 popd
 exit $retcode

=== modified file 'tests/unit/tst_alarm.qml'
--- tests/unit/tst_alarm.qml	2015-07-14 21:01:03 +0000
+++ tests/unit/tst_alarm.qml	2015-07-15 22:08:18 +0000
@@ -73,6 +73,19 @@
         function initTestCase() {
             header = findChild(mainView, "MainView_Header")
             backButton = findChild(alarmTest.header, "customBackButton")
+
+            //delete all current alarms
+            waitForRendering(alarmPage)
+            var alarmsList = findChild(alarmPage, "alarmListView")
+            verify(alarmsList != null)
+            print("Found " + alarmsList.count + " pre-existing alarms")
+
+            for (var i=0; i<alarmsList.count; i++) {
+                print("Deleting Alarm " + i)
+                var alarmObject = findChild(alarmsList, "alarm"+i)
+                swipeToDeleteItem(alarmObject)
+                waitForRendering(alarmPage)
+            }
         }
 
         // *************  Helper Functions ************
@@ -125,12 +138,16 @@
         function findAlarm(label, repeat, time, status) {
             var alarmsList = findChild(alarmPage, "alarmListView")
 
+            print("Found " + alarmsList.count + " alarms")
+
             for (var i=0; i<alarmsList.count; i++) {
                 var alarmLabel = findChild(alarmsList, "listAlarmLabel"+i)
                 var alarmRepeat = findChild(alarmsList, "listAlarmSubtitle"+i)
                 var alarmTime = findChild(alarmsList, "listAlarmTime"+i)
                 var alarmStatus = findChild(alarmsList, "listAlarmStatus"+i)
 
+                print("Checking Alarm " + i + ", " + alarmLabel)
+
                 if (label === alarmLabel.text
                         && time === alarmTime.text
                         && repeat === alarmRepeat.text
@@ -145,7 +162,7 @@
 
         function _assertAlarmCreation(label, repeat, time, status) {
             if (findAlarm(label, repeat, time, status) === -1) {
-                fail("No Alarm found with the specified characteristics")
+                fail("No Alarm found with the specified characteristics " + label + ", " + repeat + ", " + time + ", " + status)
             }
         }
 
@@ -198,12 +215,11 @@
             _pressListItem(addAlarmPage, "alarmSound")
             var alarmSoundPage = getPage(pageStack, "alarmSoundPage")
             _setAlarmSound(alarmSoundPage)
+
             pressButton(backButton)
-
             waitForRendering(addAlarmPage)
 
             pressHeaderButton(header, "saveAlarmAction")
-
             waitForRendering(alarmPage)
         }
 
@@ -265,14 +281,15 @@
 
         function test_01_createAlarm_data() {
             return [
-                        {tag: "Weekday Alarms",   name: "Weekday Alarm",    repeat: [0,1,2,3,4], repeatLabel: "Weekdays"},
-                        {tag: "Weekend Alarms",   name: "Weekend Alarm",    repeat: [5,6],       repeatLabel: "Weekends"},
-                        {tag: "Random Day Alarm", name: "Random Day Alarm", repeat: [1,3],       repeatLabel: String("%1, %2").arg(Qt.locale().standaloneDayName(2, Locale.LongFormat)).arg(Qt.locale().standaloneDayName(4, Locale.LongFormat))}
+                        {tag: "Weekday Alarms",   name: "Weekday Alarm",    repeat: [1,2,3,4,5], repeatLabel: "Weekdays"},
+                        {tag: "Weekend Alarms",   name: "Weekend Alarm",    repeat: [0,6],       repeatLabel: "Weekends"},
+                        {tag: "Mixed Alarm", name: "Random Day Alarm", repeat: [1,6],       repeatLabel: String("%1, %2").arg(Qt.locale().standaloneDayName(2, Locale.LongFormat)).arg(Qt.locale().standaloneDayName(4, Locale.LongFormat))}
                     ]
         }
 
         // Test to check if creating an alarm works as expected
         function test_01_createAlarm(data) {
+            skip("Alarms utilize external dependencies. As such they are too time sensitive for unit tests")
             var date = new Date()
             date.setHours((date.getHours() + 10) % 24)
             date.setMinutes((date.getMinutes() + 40) % 60)
@@ -290,6 +307,7 @@
 
         // Test to check if editing an alarm and saving it works as expected
         function test_02_editAlarm() {
+            skip("Alarms utilize external dependencies. As such they are too time sensitive for unit tests")
             var date = new Date()
             date.setHours((date.getHours() + 10) % 24)
             date.setMinutes((date.getMinutes() + 40) % 60)