ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/music-app/fix-1475768 into lp:music-app.

Commit message:
Refresh cover art when model count changes

Requested reviews:
  Music App Developers (music-app-dev)
Related bugs:
  Bug #1475768 in Ubuntu Music App: "Playlist cover art does not update when a track is added from the Now Playing page"
  https://bugs.launchpad.net/music-app/+bug/1475768

For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-1475768/+merge/265185

Refresh cover art when model count changes
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/fix-1475768 into lp:music-app.

=== modified file 'app/ui/SongsView.qml'
--- app/ui/SongsView.qml	2015-07-01 01:42:04 +0000
+++ app/ui/SongsView.qml	2015-07-17 22:36:26 +0000
@@ -164,9 +164,6 @@
                 playlistChangedHelper()  // update recent/playlist models
 
                 albumTracksModel.filterPlaylistTracks(songStackPage.line2)
-
-                // refresh cover art
-                songStackPage.covers = Playlists.getPlaylistCovers(songStackPage.line2)
             }
         }
     ]
@@ -189,6 +186,9 @@
         model: isAlbum ? songsModel : albumTracksModel.model
         objectName: "songspage-listview"
         width: parent.width
+
+        onCountChanged: songStackPage.covers = Playlists.getPlaylistCovers(songStackPage.line2)
+
         header: BlurredHeader {
             id: blurredHeader
             rightColumn: Column {
@@ -357,9 +357,6 @@
                         playlistChangedHelper()  // update recent/playlist models
 
                         albumTracksModel.filterPlaylistTracks(songStackPage.line2)
-
-                        // refresh cover art
-                        songStackPage.covers = Playlists.getPlaylistCovers(songStackPage.line2)
                     }
                 }
             }