ubuntu-touch-coreapps-reviewers team mailing list archive

[Roman Shchekin <mrqtros@xxxxxxxxx>]

Roman Shchekin has proposed merging lp:~mrqtros/ubuntu-docviewer-app/lo-tiled-rendering-inline into lp:~ubuntu-docviewer-dev/ubuntu-docviewer-app/lo-tiled-rendering.

Commit message:
 Inlining can make code more efficient in such cases.

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/lo-tiled-rendering-inline/+merge/265206

 Inlining can make code more efficient in such cases.
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~mrqtros/ubuntu-docviewer-app/lo-tiled-rendering-inline into lp:~ubuntu-docviewer-dev/ubuntu-docviewer-app/lo-tiled-rendering.

=== modified file 'src/plugin/libreofficetoolkit-qml-plugin/twips.h'
--- src/plugin/libreofficetoolkit-qml-plugin/twips.h	2015-07-04 16:00:33 +0000
+++ src/plugin/libreofficetoolkit-qml-plugin/twips.h	2015-07-19 07:34:47 +0000
@@ -30,11 +30,11 @@
 class Twips
 {
 public:
-    static int convertTwipsToPixels(int twips, qreal zoom = 1.0) {
+    static inline int convertTwipsToPixels(int twips, qreal zoom = 1.0) {
         return int(twips / 1440.0 * VIRTUAL_DPI * zoom);
     }
 
-    static int convertPixelsToTwips(int pixels, qreal zoom = 1.0) {
+    static inline int convertPixelsToTwips(int pixels, qreal zoom = 1.0) {
         return int(pixels * 1440.0 / VIRTUAL_DPI / zoom);
     }
 };