ubuntu-touch-coreapps-reviewers team mailing list archive

[Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>]

Bartosz Kosiorek has proposed merging lp:~gang65/ubuntu-clock-app/ubuntu-clock-raplace-icon into lp:ubuntu-clock-app.

Commit message:
Replace location icon with default Suru (LP: #1476580)

Requested reviews:
  Ubuntu Clock Developers (ubuntu-clock-dev)
Related bugs:
  Bug #1476580 in Ubuntu Clock App: "Replace hardcoded location icon in the main page with the default system one"
  https://bugs.launchpad.net/ubuntu-clock-app/+bug/1476580

For more details, see:
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-raplace-icon/+merge/265384

Replace location icon with default Suru (LP: #1476580)
-- 
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~gang65/ubuntu-clock-app/ubuntu-clock-raplace-icon into lp:ubuntu-clock-app.

=== modified file 'app/clock/ClockPage.qml'
--- app/clock/ClockPage.qml	2015-05-27 16:03:23 +0000
+++ app/clock/ClockPage.qml	2015-07-21 11:44:21 +0000
@@ -262,11 +262,11 @@
                 horizontalCenter: parent.horizontalCenter
             }
 
-            Image {
+            Icon {
                 id: locationIcon
-                source: "../graphics/Location_Pin.png"
-                width: units.gu(1.2)
+                name: "location"
                 height: units.gu(2.2)
+                color: "Grey"
             }
 
             Label {

=== removed file 'app/graphics/Location_Pin.png'
Binary files app/graphics/Location_Pin.png	2014-06-09 15:25:39 +0000 and app/graphics/Location_Pin.png	1970-01-01 00:00:00 +0000 differ
=== modified file 'debian/changelog'
--- debian/changelog	2015-07-19 17:31:21 +0000
+++ debian/changelog	2015-07-21 11:44:21 +0000
@@ -14,6 +14,7 @@
   [ Bartosz Kosiorek ]
   * Add more time choices for snooze time (LP: #1450767)
   * Move empty state clue higher (LP: #1430465)
+  * Replace location icon with default Suru (LP: #1476580)
 
  -- Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>  Sun, 05 Jul 2015 15:10:12 +0200