ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/music-app/fix-1478162 into lp:music-app.

Commit message:
* Fix to allow the LibraryEmptyState to work again

Requested reviews:
  Music App Developers (music-app-dev)
Related bugs:
  Bug #1478162 in Ubuntu Music App: "[music] Library empty state does not work on wily"
  https://bugs.launchpad.net/music-app/+bug/1478162

For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-1478162/+merge/265885

* Fix to allow the LibraryEmptyState to work again

A minor bug in the ContentHubHelper was causing the LibraryEmptyState to not work properly. It may have been causing other issues that we were working around. So things related to ContentHub should probably be retested for surface level failures.

I want this to land prior to releasing the next revision of the app to the app store.
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/fix-1478162 into lp:music-app.

=== modified file 'app/components/Helpers/ContentHubHelper.qml'
--- app/components/Helpers/ContentHubHelper.qml	2015-06-29 23:50:12 +0000
+++ app/components/Helpers/ContentHubHelper.qml	2015-07-25 01:25:27 +0000
@@ -28,7 +28,7 @@
     property var activeTransfer
     property int importId: 0
     property list<ContentItem> importItems
-    property bool processing: contentHubWaitForFile !== -1
+    property bool processing: contentHubWaitForFile.processId !== -1
 
     ContentTransferHint {
         anchors {

=== modified file 'debian/changelog'
--- debian/changelog	2015-07-24 02:09:59 +0000
+++ debian/changelog	2015-07-25 01:25:27 +0000
@@ -2,6 +2,7 @@
 
   [ Victor Thompson ]
   * Fix SongsView album art for albums and genres
+  * Fix to allow the LibraryEmptyState to work again 
 
  -- Victor Thompson <victor.thompson@xxxxxxxxx>  Thu, 23 Jul 2015 21:08:38 -0500