← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~nskaggs/ubuntu-clock-app/add-lxml-depends into lp:ubuntu-clock-app

 

Nicholas Skaggs has proposed merging lp:~nskaggs/ubuntu-clock-app/add-lxml-depends into lp:ubuntu-clock-app.

Commit message:
Add missing lxml depends

Requested reviews:
  Ubuntu Clock Developers (ubuntu-clock-dev)

For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-clock-app/add-lxml-depends/+merge/266037

The AP tests import lxml in python. This need python3-lxml in order to work.
-- 
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-clock-app/add-lxml-depends into lp:ubuntu-clock-app.
=== modified file 'debian/control'
--- debian/control	2014-10-28 18:55:15 +0000
+++ debian/control	2015-07-27 20:53:42 +0000
@@ -46,6 +46,7 @@
 Architecture: all
 Depends: libautopilot-qt,
          libqt5test5,
+         python3-lxml,
          ubuntu-clock-app (>= ${source:Version}),
          ubuntu-ui-toolkit-autopilot,
          ${misc:Depends},

=== modified file 'manifest.json.in'
--- manifest.json.in	2015-07-24 16:17:11 +0000
+++ manifest.json.in	2015-07-27 20:53:42 +0000
@@ -15,8 +15,13 @@
     "version": "3.5.@BZR_REVNO@",
     "maintainer": "Ubuntu App Cats <ubuntu-touch-coreapps@xxxxxxxxxxxxxxxxxxx>",
     "x-test": {
-        "autopilot": "ubuntu_clock_app"
-    },
+        "autopilot": {
+            "autopilot_module": "@AUTOPILOT_DIR@",
+            "depends": [
+                "python3-lxml"
+            ]
+        }
+    }
     "x-source": {
         "vcs-bzr": "@BZR_SOURCE@",
         "vcs-bzr-revno": "@BZR_REVNO@"


Follow ups