ubuntu-touch-coreapps-reviewers team mailing list archive

[Ricardo Salveti <rsalveti@xxxxxxxxxxxx>]

Review: Needs Fixing



Diff comments:

> === modified file 'app/alarm/AlarmSettingsPage.qml'
> --- app/alarm/AlarmSettingsPage.qml	2015-07-07 20:54:57 +0000
> +++ app/alarm/AlarmSettingsPage.qml	2015-07-15 01:26:27 +0000
> @@ -30,6 +32,11 @@
>      visible: false
>      flickable: settingsPlugin
>  
> +    Audio {
> +        id: previewAlarmVolume
> +        audioRole: MediaPlayer.alert
> +    }
> +

If preview is alarm, the role should be MediaPlayer.alarm instead.

>      Connections {
>          target: clockApp
>          onApplicationStateChanged: {
> @@ -110,10 +117,14 @@
>  
>                      minimumValue: 1
>                      maximumValue: 100
> +                    live: true
>                      value: alarmSettings.volume
>  
>                      onValueChanged: {
> -                        alarmSettings.volume = formatValue(value)
> +                        alarmSettings.volume = value
> +                        previewAlarmVolume.volume = value/100
> +                        previewAlarmVolume.source = "/usr/share/sounds/ubuntu/ringtones/Suru arpeggio.ogg"
> +                        previewAlarmVolume.play()
>                      }

I don't see why it would not work with utouch, since it also worked on your desktop. Try with the alarm role and see if makes any difference.

One way to help me understanding what is happening is also checking the logs from pulseaudio (since you can check the real volume that gets used by it).
Run (on a writable system) "sudo sed -i 's/--start/--start --log-level=debug/g' /usr/share/upstart/sessions/pulseaudio.conf", reboot, and then paste your /var/log/syslog so we can understand what is happening at the pulseaudio layer.

>                  }
>              }


-- 
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-volume-preview/+merge/264783
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.