ubuntu-touch-coreapps-reviewers team mailing list archive

[Riccardo Padovani <riccardo@xxxxxxxxxxxxx>]

Review: Approve

Works like a charm, thanks :-)

Diff comments:

> 
> === modified file 'src/app/qml/reminders.qml'
> --- src/app/qml/reminders.qml	2015-06-22 10:53:02 +0000
> +++ src/app/qml/reminders.qml	2015-07-25 03:01:57 +0000
> @@ -501,7 +490,7 @@
>  
>      Column {
>          id: statusBar
> -        anchors { left: parent.left; right: parent.right; top: parent.top; topMargin: units.gu(9) }
> +        anchors { left: parent.left; right: parent.right; top: parent.top; topMargin: units.gu(6)}

Nitpick here: be consistent, one space or no space near both braces :-)

>  
>          StatusBar {
>              anchors { left: parent.left; right: parent.right }


-- 
https://code.launchpad.net/~mzanetti/reminders-app/uitk-1.3/+merge/265886
Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app.