ubuntu-touch-coreapps-reviewers team mailing list archive

[Riccardo Padovani <riccardo@xxxxxxxxxxxxx>]

Riccardo Padovani has proposed merging lp:~rpadovani/reminders-app/predictiveTextTagInsertion into lp:reminders-app.

Commit message:
Fix bug about tag insertion when user is still typing the tag name

Requested reviews:
  Ubuntu Reminders app developers (reminders-app-dev)
Related bugs:
  Bug #1478094 in Ubuntu Notes app: "Tags wil not allow you to tap okay until the word is released from the keyboard"
  https://bugs.launchpad.net/reminders-app/+bug/1478094

For more details, see:
https://code.launchpad.net/~rpadovani/reminders-app/predictiveTextTagInsertion/+merge/266215

Fix bug #1478094
-- 
Your team Ubuntu Reminders app developers is requested to review the proposed merge of lp:~rpadovani/reminders-app/predictiveTextTagInsertion into lp:reminders-app.

=== modified file 'src/app/qml/components/EditTagsDialog.qml'
--- src/app/qml/components/EditTagsDialog.qml	2015-06-16 23:43:54 +0000
+++ src/app/qml/components/EditTagsDialog.qml	2015-07-29 11:36:17 +0000
@@ -141,7 +141,7 @@
             id: okButton
             text: i18n.tr("OK")
             color: UbuntuColors.orange
-            enabled: textField.text.replace(/\s+/g, '') !== ''; // Not only whitespaces!
+            enabled: textField.text.replace(/\s+/g, '') !== '' || textField.inputMethodComposing === true; // Not only whitespaces!
             onClicked: textField.accept()
         }
     }