ubuntu-touch-coreapps-reviewers team mailing list archive

[Mihir Soni <mihirsoni.123@xxxxxxxxx>]

Review: Needs Fixing

Hi ,

The attached bug code looks , fine it seems you have also added code for WeekNumber in this MP.

Could you please remove that and push the changes again ?

Diff comments:

> 
> === modified file 'MonthComponent.qml'
> --- MonthComponent.qml	2015-06-11 14:07:51 +0000
> +++ MonthComponent.qml	2015-07-12 03:29:02 +0000
> @@ -30,6 +30,7 @@
>  

Could you please remove this changes from current MP ?

>      property var currentMonth;
>      property var isYearView;
> +    property bool showWeekNumber:true;
>  
>      property string dayLabelFontSize: "medium"
>      property string dateLabelFontSize: "large"
> 
> === modified file 'po/com.ubuntu.calendar.pot'
> --- po/com.ubuntu.calendar.pot	2015-06-23 15:59:08 +0000
> +++ po/com.ubuntu.calendar.pot	2015-07-12 03:29:02 +0000
> @@ -8,7 +8,7 @@
>  msgstr ""

Also , please revert the .pot files each time you create MP.

>  "Project-Id-Version: \n"
>  "Report-Msgid-Bugs-To: \n"
> -"POT-Creation-Date: 2015-06-23 23:57+0800\n"
> +"POT-Creation-Date: 2015-07-11 19:28+0800\n"
>  "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
>  "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
>  "Language-Team: LANGUAGE <LL@xxxxxx>\n"


-- 
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1440583/+merge/264487
Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app.