ubuntu-touch-coreapps-reviewers team mailing list archive

[Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>]

Nekhelesh Ramananthan has proposed merging lp:~nik90/ubuntu-clock-app/fix-qtcreator-builability into lp:ubuntu-clock-app.

Commit message:
Fixes incorrect manifest file syntax causing trunk being unable to be built and run using Qtcreator.

Requested reviews:
  Ubuntu Clock Developers (ubuntu-clock-dev)

For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-qtcreator-builability/+merge/266647

Cannot build trunk in Qtcreator due to manifest file syntax being incorrect. This MP fixes it.

13:05:23: Could not open the manifest.json file in /home/krnekhelesh/Documents/Ubuntu-Projects/Clock/builddir/build-fix-qtcreator-buildability-UbuntuSDK_for_armhf_GCC_ubuntu_sdk_15_04_vivid-Default/.ubuntu-sdk-deploy.
 Parsing failed, please check if the syntax is correct.

Please check if MPs run using Qtcreator on the phone before approving them to avoid issues like this in the future.
-- 
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/fix-qtcreator-builability into lp:ubuntu-clock-app.

=== modified file 'manifest.json.in'
--- manifest.json.in	2015-07-27 20:52:03 +0000
+++ manifest.json.in	2015-08-01 11:10:59 +0000
@@ -21,7 +21,7 @@
                 "python3-lxml"
             ]
         }
-    }
+    },
     "x-source": {
         "vcs-bzr": "@BZR_SOURCE@",
         "vcs-bzr-revno": "@BZR_REVNO@"