ubuntu-touch-coreapps-reviewers team mailing list archive

[Arto Jalkanen <ajalkane@xxxxxxxxx>]

Review: Approve

Same note as in previous MP, hard-coded length of start of trash url would be best be a constant or logic in LocationUrl

Diff comments:

> === modified file 'src/plugin/folderlistmodel/trash/trashlocation.cpp'
> --- src/plugin/folderlistmodel/trash/trashlocation.cpp	2015-03-01 15:32:42 +0000
> +++ src/plugin/folderlistmodel/trash/trashlocation.cpp	2015-07-19 15:32:02 +0000
> @@ -314,3 +314,16 @@
>      }
>      return new TrashListWorker(trashDir, urlPath, filter);
>  }
> +
> +
> +QString TrashLocation::urlBelongsToLocation(const QString &urlPath, int indexOfColonAndSlashe)
> +{
> +    QString ret;
> +#if defined(Q_OS_UNIX)
> +    if (urlPath.startsWith(LocationUrl::TrashRootURL.midRef(0,6)))

Same note as in previous MP, hard-coded length of start of trash url would be best be a constant or logic in LocationUrl

> +    {
> +        ret  = LocationUrl::TrashRootURL + DirItemInfo::removeExtraSlashes(urlPath, indexOfColonAndSlashe+1);
> +    }
> +#endif
> +    return ret;
> +}


-- 
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-10/+merge/265209
Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app.