ubuntu-touch-coreapps-reviewers team mailing list archive

[Arto Jalkanen <ajalkane@xxxxxxxxx>]

Review: Needs Fixing

See diff comment.

Diff comments:

> 
> === added file 'src/plugin/folderlistmodel/disk/disklocationitemdir.cpp'
> --- src/plugin/folderlistmodel/disk/disklocationitemdir.cpp	1970-01-01 00:00:00 +0000
> +++ src/plugin/folderlistmodel/disk/disklocationitemdir.cpp	2015-07-19 16:39:36 +0000
> @@ -0,0 +1,61 @@
> +/**************************************************************************
> + *
> + * Copyright 2015 Canonical Ltd.
> + * Copyright 2015 Carlos J Mazieri <carlos.mazieri@xxxxxxxxx>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU Lesser General Public License as published by
> + * the Free Software Foundation; version 3.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + *
> + * File: disklocationitemdir.cpp
> + * Date: 16/05/2015
> + */
> +
> +#include "disklocationitemdir.h"
> +#include <QDir>
> +
> +DiskLocationItemDir::DiskLocationItemDir(const QString &dir) : LocationItemDir(dir), m_qtQDir(new QDir())
> +{
> +    if(!dir.isNull() && !dir.isEmpty())
> +    {
> +        m_qtQDir->setPath(dir);
> +    }
> +}
> +
> +
> +DiskLocationItemDir::~DiskLocationItemDir()
> +{
> +

m_qtQDir is not deleted, memory leak?

> +}
> +
> +bool DiskLocationItemDir::exists() const
> +{
> +    return m_qtQDir->exists();
> +}
> +
> +
> +bool DiskLocationItemDir::mkdir(const QString& dir) const
> +{
> +    return m_qtQDir->mkdir(dir);
> +}
> +
> +
> +bool DiskLocationItemDir::mkpath(const QString& dir) const
> +{
> +     return m_qtQDir->mkpath(dir);
> +}
> +
> +
> +bool DiskLocationItemDir::rmdir(const QString& dir) const
> +{
> +    return m_qtQDir->rmdir(dir);
> +}
> +


-- 
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-14/+merge/265213
Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app.