ubuntu-touch-coreapps-reviewers team mailing list archive

[Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>]

Bartosz Kosiorek has proposed merging lp:~gang65/ubuntu-clock-app/ubuntu-clock-alarm-stops-after into lp:ubuntu-clock-app.

Commit message:
Change "Silence after" to "Alarm stops afer" according to UX design

Requested reviews:
  Ubuntu Clock Developers (ubuntu-clock-dev)

For more details, see:
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-alarm-stops-after/+merge/267715

Change "Silence after" to "Alarm stops afer" according to UX design

-- 
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~gang65/ubuntu-clock-app/ubuntu-clock-alarm-stops-after into lp:ubuntu-clock-app.

=== modified file 'app/alarm/AlarmSettingsPage.qml'
--- app/alarm/AlarmSettingsPage.qml	2015-07-24 13:27:30 +0000
+++ app/alarm/AlarmSettingsPage.qml	2015-08-11 20:42:20 +0000
@@ -50,7 +50,7 @@
         Component.onCompleted: initialise()
 
         function initialise() {
-            // TRANSLATORS: Silence after
+            // TRANSLATORS: Alarm stops after
             durationModel.append({ "duration": 10, "text": i18n.tr("%1 minute", "%1 minutes", 10).arg(10) })
             durationModel.append({ "duration": 20, "text": i18n.tr("%1 minute", "%1 minutes", 20).arg(20) })
             durationModel.append({ "duration": 30, "text": i18n.tr("%1 minute", "%1 minutes", 30).arg(30) })
@@ -122,7 +122,7 @@
                 id: _alarmDuration
 
                 listViewHeight: units.gu(28)
-                text: i18n.tr("Silence after")
+                text: i18n.tr("Alarm stops after")
                 subText: i18n.tr("%1 minute", "%1 minutes", alarmSettings.duration).arg(alarmSettings.duration)
 
                 model: durationModel

=== modified file 'debian/changelog'
--- debian/changelog	2015-08-08 18:45:05 +0000
+++ debian/changelog	2015-08-11 20:42:20 +0000
@@ -2,6 +2,7 @@
 
   [Bartosz Kosiorek]
   * Disable automatic translation and update README.translations
+  * Change "Silence after" to "Alarm stops afer" according to UX design
   
   [Nekhelesh Ramananthan]
   * Increase the height of times in the alarm screen (LP: #1365428)

=== modified file 'po/com.ubuntu.clock.pot'
--- po/com.ubuntu.clock.pot	2015-08-07 11:27:59 +0000
+++ po/com.ubuntu.clock.pot	2015-08-11 20:42:20 +0000
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2015-08-07 13:27+0200\n"
+"POT-Creation-Date: 2015-08-11 22:38+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@xxxxxx>\n"
@@ -66,7 +66,7 @@
 msgid "Settings"
 msgstr ""
 
-#. TRANSLATORS: Silence after
+#. TRANSLATORS: Alarm stops after
 #. TRANSLATORS: Snooze for
 #: ../app/alarm/AlarmSettingsPage.qml:54 ../app/alarm/AlarmSettingsPage.qml:55
 #: ../app/alarm/AlarmSettingsPage.qml:56 ../app/alarm/AlarmSettingsPage.qml:57
@@ -85,7 +85,7 @@
 msgstr ""
 
 #: ../app/alarm/AlarmSettingsPage.qml:125
-msgid "Silence after"
+msgid "Alarm stops after"
 msgstr ""
 
 #: ../app/alarm/AlarmSettingsPage.qml:163