ubuntu-touch-coreapps-reviewers team mailing list archive

[Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>]

Review: Needs Information

It is working perfectly for me, and code looks fine.

Only one small question.

Diff comments:

> === modified file 'app/alarm/AlarmDelegate.qml'
> --- app/alarm/AlarmDelegate.qml	2015-08-05 12:50:42 +0000
> +++ app/alarm/AlarmDelegate.qml	2015-08-12 14:24:17 +0000
> @@ -82,6 +89,33 @@
>                  text: type === Alarm.Repeating ? alarmUtils.format_day_string(daysOfWeek, type)
>                                                 : model.enabled ? alarmUtils.get_time_to_next_alarm(model.date - localTime)
>                                                                 : "Alarm Disabled"

Alarm disabled text will be never displayed.
Why we have such text then?
If it is needed then we need to translate it.

> +
> +                function animateTextChange() {
> +                    textChangeAnimation.start()
> +                }
> +
> +
> +                SequentialAnimation {
> +                    id: textChangeAnimation
> +                    PropertyAnimation {
> +                        target: alarmSubtitle
> +                        property: "opacity"
> +                        to: 0
> +                        duration: UbuntuAnimation.BriskDuration
> +                    }
> +
> +                    ScriptAction {
> +                        script: alarmSubtitle.text = showAlarmFrequency ? alarmUtils.format_day_string(daysOfWeek, type)
> +                                                                        : alarmUtils.get_time_to_next_alarm(model.date - localTime)
> +                    }
> +
> +                    PropertyAnimation {
> +                        target: alarmSubtitle
> +                        property: "opacity"
> +                        to: 1.0
> +                        duration: UbuntuAnimation.BriskDuration
> +                    }
> +                }
>              }
>          }
>      }


-- 
https://code.launchpad.net/~nik90/ubuntu-clock-app/alternate-alarm-information/+merge/267721
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.