ubuntu-touch-coreapps-reviewers team mailing list archive

[Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>]

Nekhelesh Ramananthan has proposed merging lp:~nik90/ubuntu-clock-app/update-default-alarm-sound into lp:ubuntu-clock-app.

Commit message:
Changed default alarm sound to "Alarm clock"

Requested reviews:
  Ubuntu Clock Developers (ubuntu-clock-dev)
Related bugs:
  Bug #1354370 in Ubuntu Clock App: "[Alarm][UX] default sound for alarm doesn't get its job done"
  https://bugs.launchpad.net/ubuntu-clock-app/+bug/1354370

For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/update-default-alarm-sound/+merge/267953

Changed default alarm sound to "Alarm clock". 

Please do note that this sound file will not land in Ubuntu Vivid. It will be part of the stable phone images from OTA-6. So when testing on vivid desktop, expect the alarm sound to be invalid.
-- 
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/update-default-alarm-sound into lp:ubuntu-clock-app.

=== modified file 'app/alarm/EditAlarmPage.qml'
--- app/alarm/EditAlarmPage.qml	2015-06-03 22:49:29 +0000
+++ app/alarm/EditAlarmPage.qml	2015-08-13 13:53:27 +0000
@@ -207,7 +207,7 @@
                   When folder model is completely loaded, proceed to perform
                   the following operations,
 
-                  if new alarm, then set the sound name as "Suru arpeggio" and
+                  if new alarm, then set the sound name as "Alarm clock" and
                   retrieve the sound path from the folder model to assign to
                   the alarm model sound property.
 
@@ -298,7 +298,7 @@
             objectName: "alarmSound"
 
             // Default Alarm Sound for new alarms
-            property string _soundName: "Suru arpeggio"
+            property string _soundName: "Alarm clock"
 
             text: i18n.tr("Sound")
             onClicked: pageStack.push(Qt.resolvedUrl("AlarmSound.qml"), {

=== modified file 'debian/changelog'
--- debian/changelog	2015-08-12 21:01:20 +0000
+++ debian/changelog	2015-08-13 13:53:27 +0000
@@ -9,6 +9,7 @@
   * Fixed the confusing behavior of the confirmation button (LP: #1408015)
   * Added README.mergeproposal checklist to help with the review process.
   * Fix alarm interval information being inconsistent (LP: #1466000)
+  * Changed default alarm sound (LP: #1354370)
 
   [Victor Thompson]
   * Show all README files in QtCreator