ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~ubuntu-weather-dev/ubuntu-weather-app/reboot-finish-listitem-migration into lp:ubuntu-weather-app/reboot

To: mp+266981@xxxxxxxxxxxxxxxxxx
From: Victor Thompson <victor.thompson@xxxxxxxxx>
Date: Fri, 14 Aug 2015 01:48:01 -0000
In-reply-to: <20150805001826.29122.82464.launchpad@ackee.canonical.com>
Reply-to: mp+266981@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

> Should this have // CUSTOM as a note incase we do a pull of upstream and miss that we made changes?
Sure. I added a comment. I think eventually this will be folded into the SDK anyway. They already pulled in a hint component that we should make use of soonish.

> Why was this changed it looks the same just with  { } around it?
No reason that I know of. I didn't like it either when I was resolving merge conflicts. Updated.

> Not A->Z
Fixed.
-- 
https://code.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/reboot-finish-listitem-migration/+merge/266981
Your team Ubuntu Weather Developers is subscribed to branch lp:~ubuntu-weather-dev/ubuntu-weather-app/reboot-finish-listitem-migration.

References

[Merge] lp:~ubuntu-weather-dev/ubuntu-weather-app/reboot-finish-listitem-migration into lp:ubuntu-weather-app/reboot
From: Victor Thompson, 2015-08-05