← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Re: [Merge] lp:~nik90/ubuntu-clock-app/improve-alarm-name-eliding-ruling into lp:ubuntu-clock-app

 

Review: Approve

Very nice improvement. It works perfectly for me.
*   Does the MP add/remove user visible strings? If Yes, has the pot file been
    updated?
No
*   Does the MP change the UI? If Yes, has it been approved by design?
No
*   Did you perform an exploratory manual test run of your code change and any
    related functionality?
I tested it on Desktop
*   If the MP fixes a bug or implements a feature, are there accompanying unit
    and autopilot tests?
Not needed
*   Is the clock app trunk buildable and runnable using Qtcreator?
Yes
*   Was the debian changelog updated?

Not needed
*   Was the copyright years updated if necessary?
Not needed
-- 
https://code.launchpad.net/~nik90/ubuntu-clock-app/improve-alarm-name-eliding-ruling/+merge/268268
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.


References