ubuntu-touch-coreapps-reviewers team mailing list archive

[Andrew Hayzen <ahayzen@xxxxxxxxx>]

The proposal to merge lp:~ahayzen/music-app/fix-1357324-content-hub-source into lp:music-app has been updated.

Description changed to:

* Add support for a content-hub source in both single and multiple selection modes

TESTING:
Install the test importer:
bzr branch lp:~ahayzen/+junk/hub-importer-music-patches
cd hub-importer-music-patches
click build .
adb push *.click /tmp/my.click
adb shell pkcon install-local --allow-untrusted /tmp/my.click

Install the new music app (if it has the same rev restart the device as the new apparmor profile won't be refreshed)

Open the hub-importer, select "Import contacts" then Music. When in singular mode only 1 track can be selected and imported and when in multiple many tracks can be selected. The X should cancel the import. You can change the selection type from singular to multiple here [0].

Test with the app both open and closed beforehand (if it is closed the app will close after the transfer is complete [there is a bug in the shell which sometimes means it remains shown in the spread when it has actually quit] if it is open it will remain open).

Notes:
If the app is started by an import for the first time, should it show the walkthrough? If it is not to show the walkthrough we need to ensure that the current code cannot by layered incorrectly.

Also to test the end-to-end goal there is a clock MP [1]

0 - http://bazaar.launchpad.net/~ahayzen/+junk/hub-importer-music-patches/view/head:/hub-importer.qml#L299
1 - https://code.launchpad.net/~nik90/ubuntu-clock-app/custom-alarm-sound/+merge/268499

For more details, see:
https://code.launchpad.net/~ahayzen/music-app/fix-1357324-content-hub-source/+merge/268391
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~ahayzen/music-app/fix-1357324-content-hub-source into lp:music-app.