ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~ubuntu-clock-dev/ubuntu-clock-app/stopwatch-feature-extended into lp:~ubuntu-clock-dev/ubuntu-clock-app/stopwatch-feature-staging

To: Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>
From: Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>
Date: Thu, 20 Aug 2015 16:25:06 -0000
In-reply-to: <20150816132033.26698.13546.launchpad@ackee.canonical.com>
Reply-to: mp+268171@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review, testing

@bartosz I made the following changes to your MP,

1. Renamed plugin to Stopwatch.LapHistory. (Much before our discussion yesterday. We can get back to this in a MP during the weekend) For now let's leave it as such

2. Added comments, fixme to the plugin for better understandability.

3. Stopwatch laps are stored in com.ubuntu.clock.conf file itself in the [Stopwatch] category.

4. Removed the int count() function since we don't need it anymore in the QML side.

Personally I think this branch is ready and so I am approving. Feel free to go through it once more on your own, test it and then top-approve it. Then we merge it into the stopwatch-staging branch and the merge that branch to trunk tonight.

-- 
https://code.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/stopwatch-feature-extended/+merge/268171
Your team Ubuntu Clock Developers is subscribed to branch lp:~ubuntu-clock-dev/ubuntu-clock-app/stopwatch-feature-staging.

References

[Merge] lp:~ubuntu-clock-dev/ubuntu-clock-app/stopwatch-feature-extended into lp:~ubuntu-clock-dev/ubuntu-clock-app/stopwatch-feature-staging
From: Nekhelesh Ramananthan, 2015-08-16