ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~nik90/ubuntu-clock-app/add-utility-backend into lp:ubuntu-clock-app

To: Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>
From: Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>
Date: Thu, 20 Aug 2015 21:16:42 -0000
In-reply-to: <20150819143334.5470.63541.launchpad@ackee.canonical.com>
Reply-to: mp+268490@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

* Does the MP add/remove user visible strings? If Yes, has the pot file been
    updated?

No strings changed.

* Does the MP change the UI? If Yes, has it been approved by design?

No UX change

* Did you perform an exploratory manual test run of your code change and any
    related functionality?

Extensive testing done on desktop and phone

* If the MP fixes a bug or implements a feature, are there accompanying unit
    and autopilot tests?

Not required

* Is the clock app trunk buildable and runnable using Qtcreator?

Yes
* Was the debian changelog updated?

Yes

* Was the copyright years updated if necessary?

Yes

-- 
https://code.launchpad.net/~nik90/ubuntu-clock-app/add-utility-backend/+merge/268490
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.