ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~nik90/ubuntu-clock-app/custom-alarm-sound into lp:ubuntu-clock-app

To: Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>
From: Andrew Hayzen <ahayzen@xxxxxxxxx>
Date: Thu, 20 Aug 2015 23:51:46 -0000
In-reply-to: <20150819152536.8616.2827.launchpad@ackee.canonical.com>
Reply-to: mp+268499@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve functional

Looks good to me and is a great addition to the platform :-)

Tested adding multiple custom alarms, removing them (note bug 1486008), previewing the audio, set an alarm in the future to check that the correct sound is used and tested with an empty ~/.local/share/com.ubuntu.clock (to test startup with no CustomSounds folder).

Thanks for the extra changes in supporting all audio formats :-)
-- 
https://code.launchpad.net/~nik90/ubuntu-clock-app/custom-alarm-sound/+merge/268499
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/custom-alarm-sound into lp:ubuntu-clock-app.

References

[Merge] lp:~nik90/ubuntu-clock-app/custom-alarm-sound into lp:ubuntu-clock-app
From: Nekhelesh Ramananthan, 2015-08-19