ubuntu-touch-coreapps-reviewers team mailing list archive
-
ubuntu-touch-coreapps-reviewers team
-
Mailing list archive
-
Message #04472
Re: [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-custom-sound-moving-fix into lp:ubuntu-clock-app
Review: Approve
LGTM! Nice Catch.
* Does the MP add/remove user visible strings? If Yes, has the pot file been
updated?
No
* Does the MP change the UI? If Yes, has it been approved by design?
No
* Did you perform an exploratory manual test run of your code change and any
related functionality?
Yes
* If the MP fixes a bug or implements a feature, are there accompanying unit
and autopilot tests?
No
* Is the clock app trunk buildable and runnable using Qtcreator?
Yes
* Was the debian changelog updated?
Yes
* Was the copyright years updated if necessary?
--
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-custom-sound-moving-fix/+merge/268835
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
References