ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/music-app/fix-1483962-playlist-load-perf into lp:music-app.

Commit message:
* Force playlist tracks to sync.

Requested reviews:
  Music App Developers (music-app-dev)
Related bugs:
  Bug #1483962 in Ubuntu Music App: "The SongsView for a large Playlist takes far too long to load"
  https://bugs.launchpad.net/music-app/+bug/1483962

For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-1483962-playlist-load-perf/+merge/269286

* Force playlist tracks to sync.

Testing a large playlist loading in the SongsView should be done to ensure this is performant.
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/fix-1483962-playlist-load-perf into lp:music-app.

=== modified file 'app/components/LibraryListModel.qml'
--- app/components/LibraryListModel.qml	2015-05-03 16:22:31 +0000
+++ app/components/LibraryListModel.qml	2015-08-27 00:13:15 +0000
@@ -76,6 +76,8 @@
         query = Playlists.getPlaylists
         param = null
 
+        // Set syncFactor to the default and set the list to populate
+        worker.syncFactor = 5
         worker.list = Playlists.getPlaylists();
     }
 
@@ -86,6 +88,9 @@
         query = Playlists.getPlaylistTracks
         param = playlist
 
+        // Set syncFactor to 0 to get worker to fetch all items and set the list to
+        // populate
+        worker.syncFactor = 0
         worker.list = Playlists.getPlaylistTracks(playlist);
     }
 
@@ -96,6 +101,8 @@
         query = Library.getRecent
         param = null
 
+        // Set syncFactor to the default and set the list to populate
+        worker.syncFactor = 5
         worker.list = Library.getRecent();
     }
 }

=== modified file 'debian/changelog'
--- debian/changelog	2015-08-18 21:08:05 +0000
+++ debian/changelog	2015-08-27 00:13:15 +0000
@@ -5,6 +5,7 @@
   * Fix to allow the LibraryEmptyState to work again (LP: #1478162)
   * Fix typo in README.autopilot and clarify the instructions
   * Show all README files in QtCreator
+  * Force playlist tracks to sync (LP: #1483962)
 
   [ Andrew Hayzen ]
   * Fix for console errors when using the parent changed helpers