ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Review: Needs Fixing

Comments:

1. Please update the pot file for the new strings.
2. Could we indent the alarm sound delegate text? This might help to make the section headings more obvious? This is just an opinion, however.
3. As part of this MP could you make it so the when the user selects the original alarm sound in the AlarmSound page that the saveAction is still enabled? It's weird if you play a few and get back to the original and you can't save it. IMO it should always be enabled.
4. I wonder if it'd be useful to put a small play/pause toggle next to the tick box. This would make it more apparent that tapping the item again will stop the alarm playback.

Only the first issue needs to be fixed.
-- 
https://code.launchpad.net/~nik90/ubuntu-clock-app/replace-alarmsound-checkbox/+merge/269328
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.