← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~nik90/ubuntu-clock-app/backend-plugins-rename into lp:ubuntu-clock-app

To: Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>
From: Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>
Date: Fri, 28 Aug 2015 11:22:17 -0000
In-reply-to: <20150825180825.21930.54782.codereview@gac.canonical.com>
Reply-to: mp+269089@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Nice job.

One small nitpick: Instead of Settings::Settings it should be AlarmSettings::AlarmSettings.
We decided that it is more clear for developers.


-- 
https://code.launchpad.net/~nik90/ubuntu-clock-app/backend-plugins-rename/+merge/269089
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.

References

Re: [Merge] lp:~nik90/ubuntu-clock-app/backend-plugins-rename into lp:ubuntu-clock-app
From: Nekhelesh Ramananthan, 2015-08-25