ubuntu-touch-coreapps-reviewers team mailing list archive

[Andrew Hayzen <ahayzen@xxxxxxxxx>]

Review: Needs Information

Surely this comes at the cost of the left/right of the image being cut on small device width in proportion to the height and then just creates gaps on the left/right of the image when you have a large device width in proportion to the height?

Before it would be optimal for both cases, now it just seems to be optimised for one case but compromised for others. Maybe a "fill" would be better so instead ensure that the longer side is always filled, this would then remove the gaps in both cases (long/short height/width). As in the code snippet below.

size: parent.width > parent.height ? parent.width : parent.height
-- 
https://code.launchpad.net/~vthompson/music-app/music-maximize-artwork/+merge/269460
Your team Music App Developers is subscribed to branch lp:music-app.