ubuntu-touch-coreapps-reviewers team mailing list archive
-
ubuntu-touch-coreapps-reviewers team
-
Mailing list archive
-
Message #04664
[Merge] lp:~nik90/ubuntu-clock-app/replace-alarmsound-checkbox into lp:ubuntu-clock-app
The proposal to merge lp:~nik90/ubuntu-clock-app/replace-alarmsound-checkbox into lp:ubuntu-clock-app has been updated.
Description changed to:
- Replaces alarm sound page checkboxes with tick icons instead to match system-settings app
- Added section headers to separate custom and default alarm sounds
- Bumped to v3.6
The use of tick-marks allowed me to move the QML FolderListModel from the EditAlarmPage.qml to AlarmSound.page. This means we shave of the loading times of the EditAlarmPage.qml a bit.
NOTE: Please do not merge this MP before we push out the clock-app 3.5 store update since this MP will update the pot file and change strings that I won't be able to bisect from the release. QA tested and approved rev 361. I will merge upcoming spanish and chinese translation which requires the .pot file not be updated.
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/replace-alarmsound-checkbox/+merge/269328
--
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
References