ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/ubuntu-weather-app/fix-1490044-locationspage-flickable into lp:ubuntu-weather-app/reboot.

Commit message:
* Allow the LocationsPage to be flickable.

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)
Related bugs:
  Bug #1490044 in Ubuntu Weather App: "[reboot] Locations list page header is not being shown/hidden and can overlap items"
  https://bugs.launchpad.net/ubuntu-weather-app/+bug/1490044

For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/fix-1490044-locationspage-flickable/+merge/269585

* Allow the LocationsPage to be flickable.
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/fix-1490044-locationspage-flickable into lp:ubuntu-weather-app/reboot.

=== modified file 'app/ui/LocationsPage.qml'
--- app/ui/LocationsPage.qml	2015-08-19 22:44:54 +0000
+++ app/ui/LocationsPage.qml	2015-08-30 23:13:56 +0000
@@ -26,8 +26,6 @@
 Page {
     id: locationsPage
     objectName: "locationsPage"
-    // Set to null otherwise the first delegate appears +header.height down the page
-    flickable: null
     title: i18n.tr("Locations")
 
     state: locationsListView.state === "multiselectable" ? "selection" : "default"
@@ -64,6 +62,8 @@
         id: locationsListView
         anchors {
             fill: parent
+            // TODO: Fix this offset
+            topMargin: -units.gu(9)
         }
         model: ListModel {
             id: locationsModel

=== modified file 'debian/changelog'
--- debian/changelog	2015-08-27 13:47:07 +0000
+++ debian/changelog	2015-08-30 23:13:56 +0000
@@ -23,6 +23,7 @@
     selected (LP: #1482936)
   * Lock app in portrait mode
   * Get the condition text to be translated from the OWM API. (LP: #1487793)
+  * Allow the LocationsPage to be flickable. (LP: #1490044)
 
   [ Andrew Hayzen ]
   * Add mocked locations for autopilot and add a test using the data