ubuntu-touch-coreapps-reviewers team mailing list archive
-
ubuntu-touch-coreapps-reviewers team
-
Mailing list archive
-
Message #04736
[Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-reduce-image-size into lp:ubuntu-clock-app
Bartosz Kosiorek has proposed merging lp:~gang65/ubuntu-clock-app/ubuntu-clock-reduce-image-size into lp:ubuntu-clock-app.
Commit message:
Reduce size of images (with tinypng.com) to decrease click image size (LP: #1492057)
Requested reviews:
Ubuntu Clock Developers (ubuntu-clock-dev)
Related bugs:
Bug #1492057 in Ubuntu Clock App: "Inner_Clock_Texture.png file size is big compared to the rest of the image assets"
https://bugs.launchpad.net/ubuntu-clock-app/+bug/1492057
For more details, see:
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-reduce-image-size/+merge/270229
Reduce size of images (with tinypng.com) to decrease click image size (LP: #1492057)
--
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~gang65/ubuntu-clock-app/ubuntu-clock-reduce-image-size into lp:ubuntu-clock-app.
=== modified file 'app/graphics/Hour_Hand@xxxxxx'
Binary files app/graphics/Hour_Hand@xxxxxx 2014-07-10 12:22:27 +0000 and app/graphics/Hour_Hand@xxxxxx 2015-09-04 22:25:38 +0000 differ
=== modified file 'app/graphics/Inner_Clock_Texture.png' (properties changed: +x to -x)
Binary files app/graphics/Inner_Clock_Texture.png 2014-08-13 16:09:01 +0000 and app/graphics/Inner_Clock_Texture.png 2015-09-04 22:25:38 +0000 differ
=== modified file 'app/graphics/Knob@xxxxxx'
Binary files app/graphics/Knob@xxxxxx 2014-07-10 12:22:27 +0000 and app/graphics/Knob@xxxxxx 2015-09-04 22:25:38 +0000 differ
=== modified file 'app/graphics/Minute_Hand@xxxxxx'
Binary files app/graphics/Minute_Hand@xxxxxx 2014-07-10 12:22:27 +0000 and app/graphics/Minute_Hand@xxxxxx 2015-09-04 22:25:38 +0000 differ
=== modified file 'app/graphics/Second_Hand@xxxxxx'
Binary files app/graphics/Second_Hand@xxxxxx 2014-07-10 12:22:27 +0000 and app/graphics/Second_Hand@xxxxxx 2015-09-04 22:25:38 +0000 differ
=== modified file 'app/graphics/WorldClock_Placeholder.svg'
--- app/graphics/WorldClock_Placeholder.svg 2015-08-17 12:25:22 +0000
+++ app/graphics/WorldClock_Placeholder.svg 2015-09-04 22:25:38 +0000
@@ -1,22 +1,21 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<svg width="100px" height="100px" viewBox="0 0 100 100" version="1.1" xmlns="http://www.w3.org/2000/svg"; xmlns:xlink="http://www.w3.org/1999/xlink"; xmlns:sketch="http://www.bohemiancoding.com/sketch/ns";>
+<svg xmlns="http://www.w3.org/2000/svg"; xmlns:xlink="http://www.w3.org/1999/xlink"; xmlns:sketch="http://www.bohemiancoding.com/sketch/ns"; width="100px" height="100px" viewBox="0 0 100 100" version="1.1">
<!-- Generator: Sketch 3.3.3 (12072) - http://www.bohemiancoding.com/sketch -->
<title>Placeholder Icons</title>
<desc>Created with Sketch.</desc>
- <defs></defs>
+ <defs/>
<g id="Page-1" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd" sketch:type="MSPage">
<g id="Placeholder-Icons" sketch:type="MSArtboardGroup">
<g id="Timer-+-Stopwatch-+-Clock-icon" sketch:type="MSLayerGroup" transform="translate(19.000000, 17.000000)">
<g id="Clock-icon" transform="translate(0.000000, 5.000000)" sketch:type="MSShapeGroup">
- <path d="M19.7838596,0 C2.47304842,0 0,2.48317111 0,19.8659897 L0,37.1340103 C0,54.5167567 2.47304842,57 19.7838596,57 L41.2161404,57 C58.5269504,57 61,54.5167567 61,37.1340103 L61,19.8659897 C61,2.48317111 58.5269504,0 41.2161404,0 L19.7838596,0 L19.7838596,0 Z" id="rect4158" stroke="#5B5B5B" stroke-width="3"></path>
+ <path d="M19.7838596 0 C2.47304842 0 0 2.5 0 19.9 L0 37.1 C0 54.5 2.5 57 19.8 57 L41.2161404 57 C58.5269504 57 61 54.5 61 37.1 L61 19.9 C61 2.5 58.5 0 41.2 0 L19.7838596 0 L19.7838596 0 Z" id="rect4158" stroke="#5B5B5B" stroke-width="3"/>
<g id="Hands" transform="translate(17.632812, 16.884454)">
- <path d="M0.026502832,4.16418529 L12.8671875,11.6155462" id="path4219" stroke="#5B5B5B" stroke-width="3"></path>
- <path d="M12.8671875,11.6155462 L32.7118814,0.099807479" id="path4231" stroke="#5B5B5B" stroke-width="2"></path>
- <ellipse id="path4221" fill="#5B5B5B" cx="12.8570867" cy="10.6155882" rx="4.37271174" ry="4.39499998"></ellipse>
- <path d="M12.5,11.1155462 L12.5,31.7331933" id="path4223" stroke="#5B5B5B"></path>
+ <path d="M0.026502832 4.2 L12.8671875 11.6" id="path4219" stroke="#5B5B5B" stroke-width="3"/>
+ <path d="M12.8671875 11.6 L32.7118814 0.1" id="path4231" stroke="#5B5B5B" stroke-width="2"/>
+ <ellipse id="path4221" fill="#5B5B5B" cx="12.9" cy="10.6" rx="4.4" ry="4.4"/>
+ <path d="M12.5 11.1 L12.5 31.7" id="path4223" stroke="#5B5B5B"/>
</g>
</g>
</g>
</g>
</g>
-</svg>
\ No newline at end of file
+</svg>
=== modified file 'debian/changelog'
--- debian/changelog 2015-09-03 21:07:54 +0000
+++ debian/changelog 2015-09-04 22:25:38 +0000
@@ -9,12 +9,13 @@
[ Bartosz Kosiorek ]
* Fix wrong time after changing timezone, when stopwatch is running (LP: #1491024)
+ * Reduce size of images (with tinypng.com) to decrease click image size (LP: #1492057)
-- Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx> Wed, 02 Sep 2015 15:16:29 +0200
ubuntu-clock-app (3.5) vivid; urgency=medium
- [Bartosz Kosiorek]
+ [ Bartosz Kosiorek ]
* Disable automatic translation and update README.translations
* Silent warning which is displayed during clock run
* Change "Silence after" to "Alarm stops afer" according to UX design
@@ -24,7 +25,7 @@
* Keep running stopwatch even when the clock or phone is turned off (LP: #1484942)
* If custom sound file name already exists during changing alarm sound, then delete it.
- [Nekhelesh Ramananthan]
+ [ Nekhelesh Ramananthan ]
* Increase the height of times in the alarm screen (LP: #1365428)
* Implement Stopwatch feature (LP: 1437313)
* Added stopwatch keyword to the desktop file
@@ -45,14 +46,14 @@
* Fixed edited alarms when saved not updating the alarms listview (LP: #1488439)
* Reorganized backend c++ plugins with proper naming and folder structures.
- [Victor Thompson]
+ [ Victor Thompson ]
* Show all README files in QtCreator
-- Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx> Thu, 13 Aug 2015 00:03:45 +0200
ubuntu-clock-app (3.4) vivid; urgency=medium
- [Nekhelesh Ramananthan]
+ [ Nekhelesh Ramananthan ]
* Updated version to 3.4 to mark transition to vivid framework
* Fixed bottom edge title showing incorrect status on app startup (LP: #1381432)
* Migrate to Ubuntu 15.04 SDK Framework and QtQuick 2.4.
@@ -74,7 +75,7 @@
ubuntu-clock-app (3.3) utopic; urgency=medium
- [Nekhelesh Ramananthan]
+ [ Nekhelesh Ramananthan ]
* Fixed alarm string not being translatable (LP: #1380248)
* Bumped framework version to ubuntu-sdk-14.10
* Fixed the incorrect overriding of alarm delegate model value.
@@ -99,21 +100,21 @@
* Migrated to the 15.04 framework and also QtQuick 2.4
* Locked clock app orientation to portrait (LP: #1465457)
- [themeles]
+ [ themeles ]
* Fixes alarms after midnight being incorrectly enabled for the next day. (LP: #1442518)
- [Penk Chen]
+ [ Penk Chen ]
* Fixed DigitalMode time being empty in chineese locale (LP: #1458808)
- [Brendan Donegan]
+ [ Brendan Donegan ]
* Fixed AP failure by waiting for the bottom edge tip visible property to be true
before trying to swipe up the bottom edge.
- [Riccardo Padovani]
+ [ Riccardo Padovani ]
* Fixed one-time alarms not being able to be re-enabled using the alarm switch
after they have gone off once (LP: #1413027)
- [Victor Thompson]
+ [ Victor Thompson ]
* Fixed a regression in vivid where clicking an alarm sound ListItem was not
causing the CheckBox to be checked.
@@ -121,7 +122,7 @@
ubuntu-clock-app (3.2) utopic; urgency=medium
- [Nekhelesh Ramananthan]
+ [ Nekhelesh Ramananthan ]
* Fixed bottom edge hint timeout which made it possible for new users to not notice
the bottom edge action. (LP: #1357945)
* Moved DateTime object to ubuntu-clock-app.qml so that it can be used in multiple
@@ -149,7 +150,7 @@
* Customised splash screen (white background) (LP: #1377638)
* Added manual test to check disabling of alarms.
- [Akiva Shammai Avraham]
+ [ Akiva Shammai Avraham ]
* Improved the analog clock performance by updating the clock hands every second
rather than every 10 milliseconds. (LP: #1363968)
@@ -157,7 +158,7 @@
ubuntu-clock-app (3.1) utopic; urgency=medium
- [Nekhelesh Ramananthan]
+ [ Nekhelesh Ramananthan ]
* Alarm name label no longer accepts predictive text and empty
strings. (LP: #1355414)
* Synced the fast scroll component with upstream changes
@@ -197,25 +198,25 @@
* Automatically focus textfield (LP: #1372089)
* Added alarm feature qml tests and alarm sound unit tests
- [Zsombor Egri]
+ [ Zsombor Egri ]
* Fixed alarm status toggle being reverted immediately (LP: #1272337)
* Deleting an alarm causing the others to activate (if they were disabled) (LP: #1358315)
- [David Planella]
+ [ David Planella ]
* Added internationalization support (LP: #1354522)
- [Riccardo Padovani]
+ [ Riccardo Padovani ]
* Removed 'Today/Tomorow/Yesterday' text string from world clock, replaced
'No time difference' with 'Same time' (LP: #1362093)
- [Dennis O'Flaherty]
+ [ Dennis O'Flaherty ]
* Show a message to the user when the alarm list is empty (LP: #1364555)
- [Stefano Verzegnassi]
+ [ Stefano Verzegnassi ]
* Fixed wrong alignment of "Add city" button when the application is not
localized in English. (LP: #1371229)
- [Leo Arias]
+ [ Leo Arias ]
* Fixed CMake and debian/control to run the qml tests during a deb package build
-- Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx> Wed, 13 Aug 2014 15:46:12 +0200
@@ -266,31 +267,31 @@
ubuntu-clock-app (2.9) utopic; urgency=medium
- [Nekhelesh Ramananthan]
+ [ Nekhelesh Ramananthan ]
* Added multiselect mode for alarms list as per design (LP: #1349882)
* Fixed a small portion of the listitem behind left behind after
deleting it. (LP: #1354617)
* Added vibration settings option for alarms (LP: #1350017)
- [Michael Zanetti]
+ [ Michael Zanetti ]
* Improve the performance of the world city list by creating QTimeZone
objects only once as they are really slow to create. (LP: #1350433)
- [Nicholas Skaggs]
+ [ Nicholas Skaggs ]
* Tweak AP setup and launching
-- Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx> Mon, 11 Aug 2014 16:20:00 +0200
ubuntu-clock-app (2.8) utopic; urgency=medium
- [Nekhelesh Ramananthan]
+ [ Nekhelesh Ramananthan ]
* Implemented custom swipe delete for list items (LP: #1349881)
* Synced bottom edge component with upstream code
* Added fast scroll to the world city page (LP: #1349877)
* Implemented the world clock UI in the main clock page
* Added settings option to change system time in the clock app.
- [Carla Sella]
+ [ Carla Sella ]
* Setup autopilot infrastructure and added alarm test
* Added objectNames required for the AP tests
* Expanded alarm tests using scenarios to cover different days
@@ -299,7 +300,7 @@
ubuntu-clock-app (2.7) utopic; urgency=medium
- [Nekhelesh Ramananthan]
+ [ Nekhelesh Ramananthan ]
* Expanded base TimeZoneModel to also take a u1db query model
* Added more cities to the local world city list
* Improved the accuracy of the clock hour hand by taking into account the
@@ -310,33 +311,33 @@
* Encapsulated the settings icon into an abstract button to provide haptic
feedback when pressed.
- [Victor Thompson]
+ [ Victor Thompson ]
* Resolve build warning related to unused variable in the AlarmSettings plugin
-- Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx> Mon, 04 Aug 2014 11:23:30 +0200
ubuntu-clock-app (2.6) utopic; urgency=medium
- [Nekhelesh Ramananthan]
+ [ Nekhelesh Ramananthan ]
* Clock mode is now saved in u1db to remember the user preferences
* Added support for alarm setting options like alarm duration and volume
* Updated license headers
* Added support to listen to Dbus changes to the alarm settings and update
UI automatically.
- [Victor Thompson]
+ [ Victor Thompson ]
* Update digital time every second instead of every 60 seconds
-- Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx> Wed, 30 Jul 2014 10:10:23 +0200
ubuntu-clock-app (2.5) utopic; urgency=medium
- [Nekhelesh Ramananthan]
+ [ Nekhelesh Ramananthan ]
* Added a page to select world cities.
* World cities are filtered as the user types using the SDK SortFilterModel
* Added a XML file with a list of popular cities
- [Victor Thompson]
+ [ Victor Thompson ]
* Center the plus icon in PullToAdd.qml
* Use the ok icon instead of save in the edit alarm page
@@ -344,7 +345,7 @@
ubuntu-clock-app (2.4) utopic; urgency=medium
- [Nekhelesh Ramananthan]
+ [ Nekhelesh Ramananthan ]
* Fixed some issues that were noticed while running on the device for the first time
* Removed AddCityButton.qml since we use the pulltoadd component now
* Pulltoadd animation is now more reliable since it uses grid units instead of pixels
Follow ups
