ubuntu-touch-coreapps-reviewers team mailing list archive

[Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>]

Review: Needs Fixing

A couple minor points,

1. Please rename, startStopwatch() function to something like setStopwatchStartTime() since that's essentially what that function does. May be updateStopwatch() could also be renamed to getCurrentUTCTime().

2. I think we could move "running", "previousLapTime", "lapsTime" properties and even start(), update(), stop() into the c++ class and just use Stopwatch.qml for managing the UI alone. I mention this because all other stuff seems to have already been moved into the c++ class.
-- 
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-stopwatch-runtime-timezone-fix/+merge/270396
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.